Hi @W0rma

Thanks for the contribution. I was curious why you're targeting the 6.0.x branch? As that branch is for patch release for version6.x and we should not drop support of dependency versions in a patch release.

The changes (besides the one in .php-cs-fixer.dist.php) are already part of the master branch. So all it needs is work towards a release of a new mayor version. The discussion you linked has a todo list on what (ideally) needs to be done.

Also if you think the changes in .php-cs-fixer.dist.php are needed can you create a PR adding those changes to the master branch?

So all it needs is work towards a release of a new mayor version.

@DannyvdSluijs Will the next release be a major (7.0) or a minor (6.1) version?

I wasn't sure if master already contains BC breaks and my aim was to fix the deprecation warnings for the next 6.x minor version.

@W0rma Im currently to only developer pushing this project forward. Im included to work towards a 7.0.0 release.
Best would be to have a fix for master and port what ever is needed to the 6.x branch.

I'm happy to assist as far as I can. Could you create a 6.x branch so I can prepare a PR which ports the fixes for the PHP 8.4 deprecation warnings?

Ideally we get @Seldaek to rename the current 6.0.x branch to 6.x (I don't have permissions to do so) so we have a proper branch for version 6. And all the work done in master is going to be 7.0 (which I think releasing sooner than later would be the best option).

This would also help #776 move forward for other people.

@DannyvdSluijs For what it's worth, in my opinion you should be set as a project owner. You're the main person driving this library forward, and frankly the only trusted party who has time. And you're clearly in it for the long haul; you've been working on this for quite some time now. It's been wonderful to see some progress 😁

@Seldaek What do you think? I reckon giving @DannyvdSluijs those permissions seems reasonable.

Yeah that makes total sense. I've granted you owner access on the organization @DannyvdSluijs :)

@W0rma if you could revert the changes is composer.json we could merge this one. After which I'll rename the targetted branch (doing so before would close this PR) and make a new 6.x release

if you could revert the changes is composer.json we could merge this one.

@DannyvdSluijs Sure, I can do that.

Just to make sure that there is no misunderstanding: The version bump is necessary because nullable types require at least PHP 7.1 (see https://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.nullable-types).

Do you plan to add the change again after this PR is merged?

@W0rma I didn't think about that implication, thanks for pointing it out. Raising the PHP level is only something we want to do in the next mayor version (already done in the master-branch). Which makes the need for having a 7.x version even bigger to support PHP 8.4. for people that are using this library on PHP 8.4

As I would see it now we would have:

• 5.x only fixes (bugs & security).
• 6.x is there for >= PHP 5.3 and <= PHP 8.3.
• 7.x is for PHP >= 7.1

This means we can't add the nullable types natively. We could fallback to the older PHPDoc versions and leave the native type unspecified. This way we could still support PHP 8.4 for version 6.x

What do you think?

IMO this should be merged as 6.1 (like 5.3.0 dropped php <7.1) or 7.0 if you rather, so that leaves 6.0.x for php 5.3-7.1 users.. Using this these days really is not a reasonable thing anymore. It's not worth spending extra effort supporting these versions.

Up to you of course if you rather do it feel free.. but doesn't seem worth it to me.

Thanks for the clear feedback @Seldaek. That helps a lot. I hope to find time this or next week to make the 6.1 release.
This will already include the changes from this PR. Once the release is created I'll go ahead and close this PR.

@W0rma this might not feel very positive for you. But your contribution leads to the release of the next version so you're making an impact, thanks!

But your contribution leads to the release of the next version so you're making an impact

No worries, that's what I wanted to achieve 😃

Tag 6.1.0 has been released